test(v2): add integration tests for layout, agent-bridge, and dispatcher
Add 59 new vitest tests: layout.test.ts (30), agent-bridge.test.ts (11), agent-dispatcher.test.ts (18). Fix unused import in sdk-messages.test.ts. Add WebDriver E2E scaffold README. Total: 104 vitest + 29 cargo tests.
This commit is contained in:
Hibryda
parent
a2bc8838b4
commit
020dc20d4f
5 changed files with 856 additions and 1 deletions
334
v2/src/lib/agent-dispatcher.test.ts
Normal file
334
v2/src/lib/agent-dispatcher.test.ts
Normal file
|
|
@ -0,0 +1,334 @@
|
|||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
||||
|
||||
// --- Hoisted mocks ---
|
||||
|
||||
const {
|
||||
capturedCallbacks,
|
||||
mockUnlistenMsg,
|
||||
mockUnlistenExit,
|
||||
mockRestartAgent,
|
||||
mockUpdateAgentStatus,
|
||||
mockSetAgentSdkSessionId,
|
||||
mockSetAgentModel,
|
||||
mockAppendAgentMessages,
|
||||
mockUpdateAgentCost,
|
||||
mockGetAgentSessions,
|
||||
mockNotify,
|
||||
} = vi.hoisted(() => ({
|
||||
capturedCallbacks: {
|
||||
msg: null as ((msg: any) => void) | null,
|
||||
exit: null as (() => void) | null,
|
||||
},
|
||||
mockUnlistenMsg: vi.fn(),
|
||||
mockUnlistenExit: vi.fn(),
|
||||
mockRestartAgent: vi.fn(),
|
||||
mockUpdateAgentStatus: vi.fn(),
|
||||
mockSetAgentSdkSessionId: vi.fn(),
|
||||
mockSetAgentModel: vi.fn(),
|
||||
mockAppendAgentMessages: vi.fn(),
|
||||
mockUpdateAgentCost: vi.fn(),
|
||||
mockGetAgentSessions: vi.fn().mockReturnValue([]),
|
||||
mockNotify: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock('./adapters/agent-bridge', () => ({
|
||||
onSidecarMessage: vi.fn(async (cb: (msg: any) => void) => {
|
||||
capturedCallbacks.msg = cb;
|
||||
return mockUnlistenMsg;
|
||||
}),
|
||||
onSidecarExited: vi.fn(async (cb: () => void) => {
|
||||
capturedCallbacks.exit = cb;
|
||||
return mockUnlistenExit;
|
||||
}),
|
||||
restartAgent: (...args: unknown[]) => mockRestartAgent(...args),
|
||||
}));
|
||||
|
||||
vi.mock('./adapters/sdk-messages', () => ({
|
||||
adaptSDKMessage: vi.fn((raw: Record<string, unknown>) => {
|
||||
if (raw.type === 'system' && raw.subtype === 'init') {
|
||||
return [{
|
||||
id: 'msg-1',
|
||||
type: 'init',
|
||||
content: { sessionId: 'sdk-sess', model: 'claude-sonnet-4-20250514', cwd: '/tmp', tools: [] },
|
||||
timestamp: Date.now(),
|
||||
}];
|
||||
}
|
||||
if (raw.type === 'result') {
|
||||
return [{
|
||||
id: 'msg-2',
|
||||
type: 'cost',
|
||||
content: {
|
||||
totalCostUsd: 0.05,
|
||||
durationMs: 5000,
|
||||
inputTokens: 500,
|
||||
outputTokens: 200,
|
||||
numTurns: 2,
|
||||
isError: false,
|
||||
},
|
||||
timestamp: Date.now(),
|
||||
}];
|
||||
}
|
||||
if (raw.type === 'assistant') {
|
||||
return [{
|
||||
id: 'msg-3',
|
||||
type: 'text',
|
||||
content: { text: 'Hello' },
|
||||
timestamp: Date.now(),
|
||||
}];
|
||||
}
|
||||
return [];
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock('./stores/agents.svelte', () => ({
|
||||
updateAgentStatus: (...args: unknown[]) => mockUpdateAgentStatus(...args),
|
||||
setAgentSdkSessionId: (...args: unknown[]) => mockSetAgentSdkSessionId(...args),
|
||||
setAgentModel: (...args: unknown[]) => mockSetAgentModel(...args),
|
||||
appendAgentMessages: (...args: unknown[]) => mockAppendAgentMessages(...args),
|
||||
updateAgentCost: (...args: unknown[]) => mockUpdateAgentCost(...args),
|
||||
getAgentSessions: () => mockGetAgentSessions(),
|
||||
}));
|
||||
|
||||
vi.mock('./stores/notifications.svelte', () => ({
|
||||
notify: (...args: unknown[]) => mockNotify(...args),
|
||||
}));
|
||||
|
||||
// Use fake timers to control setTimeout in sidecar crash recovery
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
vi.clearAllMocks();
|
||||
capturedCallbacks.msg = null;
|
||||
capturedCallbacks.exit = null;
|
||||
mockRestartAgent.mockResolvedValue(undefined);
|
||||
mockGetAgentSessions.mockReturnValue([]);
|
||||
});
|
||||
|
||||
// We need to dynamically import the dispatcher in each test to get fresh module state.
|
||||
// However, vi.mock is module-scoped so the mocks persist. The module-level restartAttempts
|
||||
// and sidecarAlive variables persist across tests since they share the same module instance.
|
||||
// We work around this by resetting via the exported setSidecarAlive and stopAgentDispatcher.
|
||||
|
||||
import {
|
||||
startAgentDispatcher,
|
||||
stopAgentDispatcher,
|
||||
isSidecarAlive,
|
||||
setSidecarAlive,
|
||||
} from './agent-dispatcher';
|
||||
|
||||
// Stop any previous dispatcher between tests so `unlistenMsg` is null and start works
|
||||
beforeEach(() => {
|
||||
stopAgentDispatcher();
|
||||
});
|
||||
|
||||
afterEach(async () => {
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
// Need afterEach import
|
||||
import { afterEach } from 'vitest';
|
||||
|
||||
describe('agent-dispatcher', () => {
|
||||
describe('startAgentDispatcher', () => {
|
||||
it('registers sidecar message and exit listeners', async () => {
|
||||
await startAgentDispatcher();
|
||||
|
||||
expect(capturedCallbacks.msg).toBeTypeOf('function');
|
||||
expect(capturedCallbacks.exit).toBeTypeOf('function');
|
||||
});
|
||||
|
||||
it('does not register duplicate listeners on repeated calls', async () => {
|
||||
await startAgentDispatcher();
|
||||
await startAgentDispatcher(); // second call should be no-op
|
||||
|
||||
const { onSidecarMessage } = await import('./adapters/agent-bridge');
|
||||
expect(onSidecarMessage).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it('sets sidecarAlive to true on start', async () => {
|
||||
setSidecarAlive(false);
|
||||
await startAgentDispatcher();
|
||||
expect(isSidecarAlive()).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('message routing', () => {
|
||||
beforeEach(async () => {
|
||||
await startAgentDispatcher();
|
||||
});
|
||||
|
||||
it('routes agent_started to updateAgentStatus(running)', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_started',
|
||||
sessionId: 'sess-1',
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-1', 'running');
|
||||
});
|
||||
|
||||
it('routes agent_stopped to updateAgentStatus(done) and notifies', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_stopped',
|
||||
sessionId: 'sess-1',
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-1', 'done');
|
||||
expect(mockNotify).toHaveBeenCalledWith('success', expect.stringContaining('completed'));
|
||||
});
|
||||
|
||||
it('routes agent_error to updateAgentStatus(error) with message', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_error',
|
||||
sessionId: 'sess-1',
|
||||
message: 'Process crashed',
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-1', 'error', 'Process crashed');
|
||||
expect(mockNotify).toHaveBeenCalledWith('error', expect.stringContaining('Process crashed'));
|
||||
});
|
||||
|
||||
it('ignores messages without sessionId', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_started',
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentStatus).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('handles agent_log silently (no-op)', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_log',
|
||||
sessionId: 'sess-1',
|
||||
message: 'Debug info',
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentStatus).not.toHaveBeenCalled();
|
||||
expect(mockNotify).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('agent_event routing via SDK adapter', () => {
|
||||
beforeEach(async () => {
|
||||
await startAgentDispatcher();
|
||||
});
|
||||
|
||||
it('routes init event to setAgentSdkSessionId and setAgentModel', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_event',
|
||||
sessionId: 'sess-1',
|
||||
event: { type: 'system', subtype: 'init' },
|
||||
});
|
||||
|
||||
expect(mockSetAgentSdkSessionId).toHaveBeenCalledWith('sess-1', 'sdk-sess');
|
||||
expect(mockSetAgentModel).toHaveBeenCalledWith('sess-1', 'claude-sonnet-4-20250514');
|
||||
expect(mockAppendAgentMessages).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('routes cost event to updateAgentCost and updateAgentStatus', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_event',
|
||||
sessionId: 'sess-1',
|
||||
event: { type: 'result' },
|
||||
});
|
||||
|
||||
expect(mockUpdateAgentCost).toHaveBeenCalledWith('sess-1', {
|
||||
costUsd: 0.05,
|
||||
inputTokens: 500,
|
||||
outputTokens: 200,
|
||||
numTurns: 2,
|
||||
durationMs: 5000,
|
||||
});
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-1', 'done');
|
||||
});
|
||||
|
||||
it('appends messages to agent session', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_event',
|
||||
sessionId: 'sess-1',
|
||||
event: { type: 'assistant' },
|
||||
});
|
||||
|
||||
expect(mockAppendAgentMessages).toHaveBeenCalledWith('sess-1', [
|
||||
expect.objectContaining({ type: 'text', content: { text: 'Hello' } }),
|
||||
]);
|
||||
});
|
||||
|
||||
it('does not append when adapter returns empty array', () => {
|
||||
capturedCallbacks.msg!({
|
||||
type: 'agent_event',
|
||||
sessionId: 'sess-1',
|
||||
event: { type: 'unknown_event' },
|
||||
});
|
||||
|
||||
expect(mockAppendAgentMessages).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
describe('sidecar exit handling', () => {
|
||||
beforeEach(async () => {
|
||||
await startAgentDispatcher();
|
||||
});
|
||||
|
||||
it('marks running sessions as errored on exit', async () => {
|
||||
mockGetAgentSessions.mockReturnValue([
|
||||
{ id: 'sess-1', status: 'running' },
|
||||
{ id: 'sess-2', status: 'done' },
|
||||
{ id: 'sess-3', status: 'starting' },
|
||||
]);
|
||||
|
||||
// Trigger exit -- don't await, since it has internal setTimeout
|
||||
const exitPromise = capturedCallbacks.exit!();
|
||||
// Advance past the backoff delay (up to 4s)
|
||||
await vi.advanceTimersByTimeAsync(5000);
|
||||
await exitPromise;
|
||||
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-1', 'error', 'Sidecar crashed');
|
||||
expect(mockUpdateAgentStatus).toHaveBeenCalledWith('sess-3', 'error', 'Sidecar crashed');
|
||||
// sess-2 (done) should not be updated with 'error'/'Sidecar crashed'
|
||||
const calls = mockUpdateAgentStatus.mock.calls;
|
||||
const sess2Calls = calls.filter((c: unknown[]) => c[0] === 'sess-2');
|
||||
expect(sess2Calls).toHaveLength(0);
|
||||
});
|
||||
|
||||
it('attempts auto-restart and notifies with warning', async () => {
|
||||
const exitPromise = capturedCallbacks.exit!();
|
||||
await vi.advanceTimersByTimeAsync(5000);
|
||||
await exitPromise;
|
||||
|
||||
expect(mockRestartAgent).toHaveBeenCalled();
|
||||
expect(mockNotify).toHaveBeenCalledWith('warning', expect.stringContaining('restarting'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('stopAgentDispatcher', () => {
|
||||
it('calls unlisten functions', async () => {
|
||||
await startAgentDispatcher();
|
||||
stopAgentDispatcher();
|
||||
|
||||
expect(mockUnlistenMsg).toHaveBeenCalled();
|
||||
expect(mockUnlistenExit).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('allows re-registering after stop', async () => {
|
||||
await startAgentDispatcher();
|
||||
stopAgentDispatcher();
|
||||
await startAgentDispatcher();
|
||||
|
||||
const { onSidecarMessage } = await import('./adapters/agent-bridge');
|
||||
expect(onSidecarMessage).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('isSidecarAlive / setSidecarAlive', () => {
|
||||
it('defaults to true after start', async () => {
|
||||
await startAgentDispatcher();
|
||||
expect(isSidecarAlive()).toBe(true);
|
||||
});
|
||||
|
||||
it('can be set manually', () => {
|
||||
setSidecarAlive(false);
|
||||
expect(isSidecarAlive()).toBe(false);
|
||||
setSidecarAlive(true);
|
||||
expect(isSidecarAlive()).toBe(true);
|
||||
});
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue