From 6ea1ed1dfdc14142f21a739ca44bd32cdce0ad95 Mon Sep 17 00:00:00 2001 From: Hibryda Date: Sat, 7 Mar 2026 16:51:15 +0100 Subject: [PATCH] chore(v2): remove dead update_ssh_session method and fix stale comment - Remove unused SessionDb::update_ssh_session() and its test (SshDialog was deleted in P10, this method had no callers) - Fix stale TilingGrid reference in AgentPane comment - Eliminates the last Rust compiler warning --- v2/src-tauri/src/session.rs | 40 -------------------- v2/src/lib/components/Agent/AgentPane.svelte | 2 +- 2 files changed, 1 insertion(+), 41 deletions(-) diff --git a/v2/src-tauri/src/session.rs b/v2/src-tauri/src/session.rs index 303406c..00c2b7a 100644 --- a/v2/src-tauri/src/session.rs +++ b/v2/src-tauri/src/session.rs @@ -363,25 +363,6 @@ impl SessionDb { Ok(()) } - pub fn update_ssh_session(&self, session: &SshSession) -> Result<(), String> { - let conn = self.conn.lock().unwrap(); - conn.execute( - "UPDATE ssh_sessions SET name = ?1, host = ?2, port = ?3, username = ?4, key_file = ?5, folder = ?6, color = ?7, last_used_at = ?8 WHERE id = ?9", - params![ - session.name, - session.host, - session.port, - session.username, - session.key_file, - session.folder, - session.color, - session.last_used_at, - session.id, - ], - ).map_err(|e| format!("SSH update failed: {e}"))?; - Ok(()) - } - // --- v3: Agent message persistence --- pub fn save_agent_messages( @@ -790,27 +771,6 @@ mod tests { assert_eq!(sessions[0].id, "ssh2"); } - #[test] - fn test_update_ssh_session() { - let db = make_db(); - let mut s = make_ssh_session("ssh1", "Old Name"); - db.save_ssh_session(&s).unwrap(); - - s.name = "New Name".to_string(); - s.host = "new.example.com".to_string(); - s.port = 2222; - s.last_used_at = 9999; - db.update_ssh_session(&s).unwrap(); - - let sessions = db.list_ssh_sessions().unwrap(); - assert_eq!(sessions.len(), 1); - assert_eq!(sessions[0].name, "New Name"); - assert_eq!(sessions[0].host, "new.example.com"); - assert_eq!(sessions[0].port, 2222); - assert_eq!(sessions[0].last_used_at, 9999); - // created_at should be unchanged (UPDATE doesn't touch it) - assert_eq!(sessions[0].created_at, 1000); - } #[test] fn test_ssh_session_upsert() { diff --git a/v2/src/lib/components/Agent/AgentPane.svelte b/v2/src/lib/components/Agent/AgentPane.svelte index c00a6f6..2994bb6 100644 --- a/v2/src/lib/components/Agent/AgentPane.svelte +++ b/v2/src/lib/components/Agent/AgentPane.svelte @@ -95,7 +95,7 @@ }); // NOTE: Do NOT stop agents in onDestroy — it fires on layout changes/remounts, - // not just explicit close. Stop-on-close is handled by TilingGrid. + // not just explicit close. Stop-on-close is handled by workspace teardown. let followUpPrompt = $state('');