Commit graph

270 commits

Author SHA1 Message Date
Hibryda
683013d704 fix(electrobun): connect resize signals on WebKitWebView, not GtkWindow
KEY FIX: WebKit's GdkWindow receives all pointer events. Connecting
button-press-event on the GtkWindow never fires. Must connect on the
WebKitWebView widget itself (the Wails pattern).

C library now:
- Walks widget tree to find deepest child (WebKitWebView)
- Connects button-press + motion-notify on the WebView
- Does hit-test in C (8px border zone)
- Calls gtk_window_begin_resize_drag with real event data
- Returns TRUE to consume border clicks, FALSE for interior
2026-03-25 17:40:16 +01:00
Hibryda
f97eaa1c36 fix(electrobun): update stub HTML + 800x600 test window size 2026-03-25 17:33:33 +01:00
Hibryda
7971ffe859 fix(electrobun): simplified stub page — no RPC, relies on native C resize only 2026-03-25 17:24:55 +01:00
Hibryda
e5125e6e6e fix(electrobun): enable stub page + deferred native resize for testing 2026-03-25 17:18:09 +01:00
Hibryda
449fa3dcae feat(electrobun): native C resize lib + stub test page + deferred init
- agor_resize.c: C library with GTK signal handlers for resize
- native-resize.ts: Bun FFI wrapper for libagor-resize.so
- resize-test.html: minimal stub for isolating resize behavior
- index.ts: native resize disabled pending stability testing
- RESIZE_TEST env var for loading stub page via Vite
2026-03-25 17:01:11 +01:00
Hibryda
178e560068 feat(electrobun): native C resize library (Wails pattern)
New: agor-pty/native/agor_resize.c — C shared library that:
- Connects button-press-event on GtkWindow + WebView children in C
- Stores mouseButton, xroot, yroot, dragTime from real GTK events
- Exports agor_resize_start(edge) for Bun FFI

Build: gcc -shared -fPIC -o libagor-resize.so agor_resize.c $(pkg-config --cflags --libs gtk+-3.0)

New: ui-electrobun/src/bun/native-resize.ts — Bun FFI wrapper
App.svelte: simplified to just edge detection + RPC call
2026-03-25 16:44:51 +01:00
Hibryda
de40bcbcac fix(electrobun): disable all GTK FFI, JS-only resize via setFrame RPC
Bun segfaults (address 0x10) from prior GTK widget tree modifications
(wrapWebViewInScrolledWindow corrupted the tree). Disabled all GTK FFI
except begin_move_drag (which works). JS handles capture mouse events,
compute delta, and call window.setFrame RPC.

Clean build required: rm -rf ui-electrobun/build/

Status: resize outward works, resize inward blocked by WebView min-size.
Next: need C shared library for proper GTK signal connection.
2026-03-25 16:26:00 +01:00
Hibryda
b9169ec046 Revert "fix(electrobun): connect button-press on WebView child too (events go to deepest child)"
This reverts commit 74ec191ce9.
2026-03-25 16:15:55 +01:00
Hibryda
74ec191ce9 fix(electrobun): connect button-press on WebView child too (events go to deepest child) 2026-03-25 16:13:37 +01:00
Hibryda
e563da2b3b fix(electrobun): re-enable CSS resize handles + GTK button-press only
Motion handler crashes in Bun's JSCallback FFI bridge — disabled.
CSS handles provide cursor feedback. GTK button-press-event handles
actual resize via begin_resize_drag with real event timestamp.

Bundler issue resolved: syntax error in /* */ comment was preventing
Electrobun's bundler from compiling gtk-resize.ts.
2026-03-25 16:12:15 +01:00
Hibryda
828e97276a fix(electrobun): fix gtk-resize.ts syntax error + Buffer-based FFI pointers
Fixed malformed block comment that prevented bun bundler from compiling.
Switched from TypedArray.buffer to Buffer.alloc for FFI output pointers.
Disabled motion handler to isolate button-press resize.

NOTE: Electrobun's dev command rebuilds the bundle on every run, overwriting
manual builds. To test changes, run: bun build src/bun/index.ts --outfile
build/.../app/bun/index.js --target=bun --external=electrobun AFTER
electrobun dev finishes building, then restart the app.
2026-03-25 15:59:51 +01:00
Hibryda
e9fcd8401e feat(electrobun): native GTK resize via button-press-event signal (tao pattern)
All previous approaches failed because they initiated resize from JS
(too late, wrong timestamp, WebKit steals grab). The correct approach
(proven by Tauri/tao) is to connect button-press-event DIRECTLY on the
GtkWindow at the GTK level, BEFORE WebKitGTK processes events.

New: gtk-resize.ts
- JSCallback for button-press-event + motion-notify-event
- Hit-test in 8px border zone (same as tao's 5*scale_factor)
- begin_resize_drag with REAL event timestamp (not GDK_CURRENT_TIME)
- Returns TRUE to STOP propagation (WebKit never sees the press)
- Cursor updates on motion-notify in border zone

Removed: all JS resize handles (divs, mousemove, mouseup, RPC calls)
2026-03-25 15:25:25 +01:00
Hibryda
c4d06ca999 fix(electrobun): use window.resizeTo/moveTo for resize (proven in Chromium)
Replaced entire FFI chain (XMoveResizeWindow, begin_resize_drag,
XUngrabPointer) with standard browser APIs window.resizeTo + window.moveTo.

Proven to work in Chromium --app mode with same JS resize logic.
Frame captured synchronously via window.screenX/Y + outerWidth/Height.
Zero RPC, zero FFI, zero GTK involvement.
2026-03-25 15:07:49 +01:00
Hibryda
0e6408a447 fix(electrobun): X11 XMoveResizeWindow bypass for resize (no GTK involvement)
begin_resize_drag + XUngrabPointer still fails because GTK's layout
cycle re-asserts WebView preferred size, fighting the WM resize.

New approach: JS mousemove → XMoveResizeWindow via libX11.so.6 FFI.
Completely bypasses GTK size negotiation. GTK only receives
ConfigureNotify after the X server has already resized the window.

Added: x11SetFrame() using gdk_x11_display_get_xdisplay +
gdk_x11_window_get_xid + XMoveResizeWindow.
2026-03-25 14:19:27 +01:00
Hibryda
058ae563d5 fix(electrobun): XUngrabPointer before begin_resize_drag (SDL2 pattern)
Root cause confirmed via X11 research: WebKitGTK holds an implicit X11
pointer grab from button-press. GTK's gdk_seat_ungrab targets the wrong
device, leaving the grab active. Mutter gets AlreadyGrabbed and gives up.

Fix: call XUngrabPointer(xdisplay, CurrentTime) + XFlush directly via
libX11.so.6 FFI before begin_resize_drag. This releases ALL grabs on
the display connection, matching SDL2's proven approach.

Removed failed approaches: WebView sensitivity toggle, findWebView cache.
2026-03-25 14:06:45 +01:00
Hibryda
7bb08697d6 fix(electrobun): disable WebView sensitivity during resize to prevent grab loss
Codex review #3 identified: the issue is NOT min-size but pointer grab
conflict. WebKitGTK steals the WM's X11 pointer grab when cursor enters
the WebView during inward resize.

Fix: gtk_widget_set_sensitive(webview, false) before begin_resize_drag,
re-enable after 5s. Also added findWebView() to cache the deepest
GtkBin child pointer for fast access.
2026-03-25 13:47:05 +01:00
Hibryda
300bd30ca3 fix(electrobun): wrap WebView in GtkScrolledWindow for resize-in
Codex review #2 found: set_size_request only controls minimum, not
natural/preferred size. WebView still reports content size as natural,
causing rubber-band effect during shrink.

Fix: reparent WebKitWebView into GtkScrolledWindow via FFI with
propagate-natural-width/height=FALSE and min-content=1x1. This
decouples WebView content size from window size negotiation.

Also reverted to native begin_resize_drag (WM handles everything).
2026-03-25 13:38:29 +01:00
Hibryda
d1583f8ce4 fix(electrobun): set_size_request(1,1) not (-1,-1) + revert to begin_resize_drag
Codex review found: set_size_request(-1,-1) means "use preferred size"
which RE-ENABLES WebView content-based minimum. Using (1,1) FORCES a
1x1 minimum, actually overriding the preferred size.

Reverted to native begin_resize_drag (WM handles resize smoothly).
Fixed onResizeStart sync: e.stopPropagation() now runs BEFORE any async
work, preventing sidebar drag handler from intercepting.

Removed JS mousemove resize loop — native GTK resize is correct approach.
2026-03-25 13:24:41 +01:00
Hibryda
fd2f626c20 fix(electrobun): GTK FFI direct resize via gtk_window_resize/move
Electrobun's setSize respects WebView min-size constraint. Bypass it
with direct gtk_window_resize() + gtk_window_move() FFI calls.
clearMinSizeTree() runs on every resize frame to suppress WebView
re-propagation. gtkSetFrame() exported as new RPC endpoint.
2026-03-25 13:16:39 +01:00
Hibryda
e6635e436c fix(electrobun): JS-based window resize replaces GTK begin_resize_drag
GTK begin_resize_drag loses grip when cursor moves inward past the 6px
handle zone. Replaced with document-level mousemove/mouseup listeners
that compute delta from initial frame and call setPosition+setSize.

- clearMinSize RPC clears WebView min-size before resize starts
- Cursor locks to resize direction during drag (body.style.cursor)
- user-select disabled during drag to prevent text selection
- Frame captured async before resize starts (no race condition)
2026-03-25 13:09:15 +01:00
Hibryda
290ae8ef86 fix(electrobun): clear min-size before each resize drag (enables shrink)
WebKitWebView re-propagates content size as minimum on every layout cycle,
overriding the one-time init fix. Now clearMinSizeTree() runs right before
each gtk_window_begin_resize_drag call, allowing resize-in (shrink).

Also removed red debug background from resize handles.
2026-03-25 13:00:11 +01:00
Hibryda
d84feb6c67 fix(electrobun): enable window resize via recursive GTK min-size override
Root cause: WebKitWebView requests min_size = content_size (5120x1387 on
ultrawide), which GTK propagates to WM_NORMAL_HINTS, blocking all resize.

Fix: recursively walk the GTK widget tree (GtkWindow → GtkBin → WebView)
and call gtk_widget_set_size_request(-1, -1) on every widget. Then set
gtk_window_set_geometry_hints with min=400x300.

Result: WM_NORMAL_HINTS now shows min=10x10, window is fully resizable.
2026-03-25 12:53:24 +01:00
Hibryda
9da9d96ebd feat(electrobun): native GTK drag/resize via gtk_window_begin_resize_drag
- gtk-window.ts: FFI wrapper calling libgtk-3.so.0 directly via bun:ffi
- begin_resize_drag: delegates resize to window manager (zero CPU, smooth)
- begin_move_drag: delegates move to window manager (replaces JS drag)
- Removed all JavaScript-based drag/resize logic (no mousemove/mouseup)
- RPC: window.beginResize + window.beginMove
- Resize handles: 4px edges + 8px corners with proper cursors
2026-03-25 02:23:24 +01:00
Hibryda
48d32f6f28 fix(electrobun): use setPosition+setSize instead of setFrame, add resize throttle 2026-03-25 02:09:54 +01:00
Hibryda
cfb7dafa17 fix(electrobun): setFrame takes positional args, not object — was causing resize jump 2026-03-25 02:02:36 +01:00
Hibryda
31e7c422e4 fix(electrobun): resize race condition — use cached frame, not async getFrame 2026-03-25 01:57:21 +01:00
Hibryda
31338ad949 feat(electrobun): custom window chrome — no title bar, sidebar drag, edge resize
- titleBarStyle: "hidden" removes native GTK decoration
- Sidebar + right-bar: mousedown starts window drag (skips buttons)
- 8 resize handles (N/S/E/W + 4 corners) with 4px hot zones
- window.setFrame RPC for atomic position+size updates
- Min window size: 600x400
- Cursor feedback: grab on sidebars, directional resize on edges
- Frame persisted to SQLite on drag/resize end (debounced)
2026-03-25 01:52:17 +01:00
Hibryda
1de6c93e01 feat(electrobun): settings overhaul — fonts, shells, providers, retention, chords
- Settings drawer: responsive width clamp(24rem, 45vw, 50rem)
- System font detection: fc-list for UI fonts (preferred sans-serif starred)
  and mono fonts (Nerd Fonts starred), fallback to hardcoded lists
- Scrollback: default 5000, min 1000, step 500
- Shell detection: system.shells RPC, pre-selects $SHELL login shell
- Provider enablement: provider.scan gates toggle, unavailable shown as N/A
- Session retention: count 0-100 (0=Keep all), age 0-365 (0=Forever)
- Chord keybindings: Ctrl+K → Ctrl+S style multi-key sequences,
  1s prefix wait, arrow separator display, 26 tests passing
2026-03-25 01:42:34 +01:00
Hibryda
afaa2253de feat(electrobun): auto-detect Claude models via OAuth token from CLI credentials 2026-03-25 01:15:37 +01:00
Hibryda
a4d180d382 fix(electrobun): wizard fixes — native dialog, models, PathBrowser, ensureDir
- Native dialog: resolve to nearest existing parent dir, detect user cancel
  (exit code 1) vs actual error, add createIfMissing option
- Claude models: fallback to KNOWN_CLAUDE_MODELS (6 models) when API key
  unavailable. Adds Opus 4.6, Sonnet 4.6, Opus 4.5, Sonnet 4, Haiku 4.5,
  Sonnet 3.7. Live API paginated to limit=100.
- PathBrowser: Select button moved to sticky header (always visible).
  Current path shown compact in header with RTL ellipsis.
- files.ensureDir RPC: creates directory recursively before project creation
- files.ensureDir added to RPC schema
2026-03-25 01:05:15 +01:00
Hibryda
162b5417e4 feat(electrobun): hierarchical state tree (Rule 58)
New files:
- project-state.types.ts: all per-project state interfaces
- project-state.svelte.ts: unified per-project state with version counter
- app-state.svelte.ts: root facade re-exporting all stores as appState.*

Rewired components (no more local $state):
- ProjectCard: reads via appState.agent.* and appState.project.tab.*
- TerminalTabs: state in appState.project.terminals.*
- FileBrowser: state in appState.project.files.*
- CommsTab: state in appState.project.comms.*
- TaskBoardTab: state in appState.project.tasks.*

All follow Rule 57 (no $derived with new objects) and Rule 58
(state tree architecture, components are pure renderers).
2026-03-24 15:20:09 +01:00
Hibryda
ae4c07c160 chore: add rule 58 — hierarchical state tree architecture (mandatory) 2026-03-24 14:42:07 +01:00
Hibryda
aaeee808c3 chore: add rule 57 — Svelte 5 reactivity safety (prevent infinite loops) 2026-03-24 13:09:04 +01:00
Hibryda
20e4d2cdec fix(electrobun): eliminate $effect/$derived cycles in 3 more components
TaskBoardTab: $effect called loadTasks() which wrote ++pollToken ($state)
→ triggered $effect re-run → infinite loop. Fix: onMount instead.
Also tasksByCol $derived created new objects via .reduce/.filter.

FileBrowser: $effect read openDirs (via new Set(openDirs)) AND wrote to
it (openDirs = s) → infinite loop. Fix: onMount with fresh Set.

CommsTab: $effect called loadChannels()/loadAgents() which wrote $state
→ potential cycle. Fix: onMount instead.

Rule: NEVER use $effect for initialization that writes to $state.
Always use onMount for async init + side effects.
2026-03-24 13:03:48 +01:00
Hibryda
8d09632879 fix(electrobun): eliminate ALL $derived from ProjectCard — 0% CPU achieved
Root cause: $derived with store getter functions (.filter/.map/?.operator)
created new object references on every evaluation. Svelte 5 interpreted
these as "changed values" → triggered re-render → re-evaluated $derived
→ new references → infinite loop (115% CPU).

Fix: replaced ALL $derived in ProjectCard with plain getter functions.
Functions are called in the template — Svelte tracks the inner $state
reads but doesn't create intermediate reactive nodes that can loop.

Verified via bisect:
- Skeleton (no ProjectCard): 0% CPU
- ProjectCard with $derived: 115% CPU
- ProjectCard with plain functions: 0% CPU (0 ticks in 5s)

Also fixed: CommandPalette $effect that read+wrote selectedIdx.
2026-03-24 12:59:11 +01:00
Hibryda
774016ba11 fix(electrobun): remove read+write cycle in CommandPalette clamp selection 2026-03-24 12:54:58 +01:00
Hibryda
b2b1e429dc chore: add rule 56 — Electrobun launch sequence (PTY + Vite before app) 2026-03-24 12:19:04 +01:00
Hibryda
2709600319 fix(electrobun): isolate blink state to store, prevent prop-cascade re-renders
Root cause found via bisect: blinkVisible prop changed every 500ms,
causing complete re-render of ALL ProjectCard trees (AgentPane, Terminal,
all tabs) — even display:none content is re-evaluated by Svelte 5.

Fix: blink-store.svelte.ts owns the timer. StatusDot reads directly
from store, not from parent prop. No prop cascades.

Also: replaced $derived with .filter()/.map() (creates new arrays)
with plain functions in ProjectCard to prevent reactive loops.
2026-03-24 12:05:39 +01:00
Hibryda
d08227fc98 fix(electrobun): re-apply ALL reactive cycle fixes after backup restore
All object-creating template calls replaced with $derived locals:
filteredProjects, activeGroup, totalTokens, totalCost, wizardGroups,
wizardExistingNames. getMountedGroupIds removed entirely.
2026-03-23 22:28:21 +01:00
Hibryda
86251f9d92 fix(electrobun): eliminate remaining reactive cycles (tabs store + palette)
project-tabs-store: replaced Map reassignment (_tabs = new Map(_tabs)) with
version counter pattern. Map reassignment created new object reference on
every getActiveTab() call from $derived → infinite loop.

CommandPalette: replaced $derived COMMANDS array with plain function call.
$derived with .map() created new array every evaluation → infinite loop
when any i18n state changed.
2026-03-23 22:19:38 +01:00
Hibryda
9d45caa8df fix(electrobun): replace $effect scroll with MutationObserver in onMount
The $effect reading messages.length + requestAnimationFrame was a secondary
cause of effect_update_depth_exceeded. MutationObserver is non-reactive —
observes DOM changes directly without Svelte dependency tracking.
2026-03-23 22:07:16 +01:00
Hibryda
02560e341d fix(electrobun): remove requestAnimationFrame scroll effect (was contributing to effect cycle) 2026-03-23 22:04:33 +01:00
Hibryda
085b88107f fix(electrobun): replace object-creating store calls in template with $derived locals
getMountedGroupIds()/getFilteredProjects()/getActiveGroup()/getTotalCost/Tokens
all created new objects per render → Svelte 5 saw 'changed' → re-render → new
objects → infinite effect_update_depth_exceeded loop.

Fix: compute once in $derived variables, reference stable locals in template.
2026-03-23 22:03:12 +01:00
Hibryda
de59f0e4d0 fix(electrobun): replace tick() with requestAnimationFrame in AgentPane
tick() inside $effect triggers effect re-entry: flush_effects → tick →
flushSync → flush_effects → infinite loop (effect_update_depth_exceeded).
requestAnimationFrame defers DOM scroll to next frame outside the effect.
2026-03-23 21:46:16 +01:00
Hibryda
4a5e4d9733 fix(electrobun): attempt new-window-open handler for GTK false Ctrl+click
Root cause: WebKitGTK reports stale modifier state (0x14=Ctrl+Alt) after
SIGTERM of previous instance. Electrobun interprets this as Cmd+click and
opens a new window, which closes the main window.

Finding: when modifier state is clean (0x10, isCtrlHeld=0), the window
opens correctly. The event emitter API isn't publicly exported from
electrobun/bun — needs upstream fix or different approach.
2026-03-23 21:43:01 +01:00
Hibryda
85f55c19a6 fix(electrobun): remove i18n cycle — move lang/dir sync into setLocale() 2026-03-23 21:35:47 +01:00
Hibryda
805d1e533d fix(electrobun): loadLastSession in onMount not $effect (prevents infinite reactive cycle) 2026-03-23 21:19:30 +01:00
Hibryda
a4c0435b56 fix(electrobun): untrack blink+session timer writes to prevent effect_update_depth_exceeded 2026-03-23 21:16:54 +01:00
Hibryda
f2e8b07d7f refactor(electrobun): simplify bun backend — extract db-utils, merge handlers
- db-utils.ts: shared openDb() (WAL, busy_timeout, foreign_keys, mkdirSync)
- 5 DB modules use openDb() instead of duplicated PRAGMA boilerplate
- bttask-db shares btmsg-db's Database handle (was duplicate connection)
- misc-handlers.ts: 14 inline handlers extracted from index.ts
- index.ts: 349→195 lines (only window controls remain inline)
- updater.ts: removed dead getLastKnownVersion()
- Net reduction: ~700 lines of duplicated boilerplate
2026-03-23 21:09:57 +01:00
Hibryda
2b1194c809 refactor(electrobun): centralize all shared state into global stores
New stores:
- ui-store.svelte.ts: settingsOpen, paletteOpen, searchOpen, notifDrawerOpen,
  showWizard, settingsCategory, projectToDelete, showAddGroup, newGroupName
- project-tabs-store.svelte.ts: per-project activeTab + activatedTabs via Map

Wired:
- App.svelte: 8 inline $state removed, reads/writes via ui-store
- ProjectCard: activeTab/activatedTabs from project-tabs-store
- SettingsDrawer: activeCategory from ui-store
- CommandPalette: 4 commands call ui-store directly (no CustomEvent dispatch)

Components are now pure view layers reading from stores.
2026-03-23 20:26:07 +01:00